Skip to content

Conversation

@ktssr
Copy link
Contributor

@ktssr ktssr commented Apr 26, 2023

No description provided.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 10:28am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview Apr 28, 2023 10:28am

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 26, 2023 10:47 Inactive
@ktssr ktssr force-pushed the chore/migrate-pagination-component branch from 4fc3856 to 68cff74 Compare April 26, 2023 10:47
@ktssr ktssr requested a review from a team as a code owner April 26, 2023 10:47
@ktssr ktssr force-pushed the chore/migrate-pagination-component branch from 68cff74 to 4fc3856 Compare April 26, 2023 10:49
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 26, 2023 10:51 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 26, 2023 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 26, 2023 12:36 Inactive
@targos
Copy link
Member

targos commented Apr 26, 2023

Why do you want input from the releasers team?

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 26, 2023 13:30 Inactive
@ktssr
Copy link
Contributor Author

ktssr commented Apr 26, 2023

Why do you want input from the releasers team?

I apologize for any confusion, I am having difficulty understanding what you are trying to convey. could you please elaborate?

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 26, 2023 13:35 Inactive
@targos
Copy link
Member

targos commented Apr 26, 2023

I am in the release team and we got a notification because we were requested as reviewers:
CleanShot 2023-04-26 at 16 03 04

@ovflowd
Copy link
Member

ovflowd commented Apr 26, 2023

Really odd, @targos since the CODEWONERS shouldn't mark releasers for this changeset (https://github.com/nodejs/nodejs.org/blob/main/CODEOWNERS)

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 26, 2023 14:23 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 26, 2023 14:24 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ktssr for this amazing contribution!

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 27, 2023 01:00 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 27, 2023 01:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 28, 2023 10:27 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 28, 2023 10:28 Inactive
@ovflowd ovflowd merged commit d27d83a into nodejs:major/website-redesign Apr 28, 2023
ovflowd added a commit that referenced this pull request May 3, 2023
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
araujogui pushed a commit to araujogui/nodejs.org that referenced this pull request May 8, 2023
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
ovflowd added a commit that referenced this pull request May 14, 2023
* feat(unit-test): introduce unit test on website redesign branch (#5178

feat(unit-test): introduce unit test

* chore(minor): just a tiny design nitpick

* chore: set up storybook (#5191) (#5214)

* chore: set up testing-library jest extend (#5231)

Co-authored-by: Manish Kumar ⛄ <[email protected]>

* chore(dependencies): updated dependencies

* feat: create section title component (#5237)

Co-authored-by: Wai.Tung <[email protected]>

* 📎 chore(migration): migrate banner component (#5233)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: migrate AnimatedPlaceholder component (#5238

Migrate AnimatedPlaceholder component from nodejs.dev
and create a new Story.

* feat: create article alert component (#5243)

* feat: migrate blockquote component (#5259)

* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)

* feat: create article data tag component (#5280)

* feat: migrate AuthorList component and add story 🎉 (#5277)

Co-authored-by: Michael Esteban <[email protected]>

* chore(migration): migrate language selector component (#5266)

Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>

* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)

Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>

* chore: contributing quick fix of example

Signed-off-by: Claudio Wunder <[email protected]>

* chore: story guide and react spreading

Signed-off-by: Claudio Wunder <[email protected]>

* chore: remove base styles from old styling

* chore: fix storybook styles, imports, typescript config and dependencies (#5319

* chore: optimises tsconfig

* chiore: add missing dependencies

* chore: type storybook constants

* chore: styles moved styles to somewhere else

* chore: add global json type definition

* chore: i18n aria-label instead of sr-only

* chore: added open sans font family and space between imports

* chore: moved styles and fixed styles and updated banner stories

* fix: stylelint rules

* chore: updated tsconfig

* chore: fix tests

* fix: darkmodetoggle test

* chore: stories use index.stories.tsx

* chore: adopt turborepo (#5316

* chore: revert pnpm use plain npm

* fix: package.json

* chore: remove warnings and add node_env

* chore: cross-env

* fix: fix turbo pipelines

* chore: only cache certain files

* chore: turbo shouldn't care about coverage outputs

* chore: proper inputs and outputs for pipelines

* chore: do not store some outputs and updated inputs for lint

* chore: added prettier configs

* chore: remove console.info

* chore: updated inputs of all other entries

* fix(package.json) Lint command is missing slashes (#5321

fix(package.json) lint:fix missing slashes

* moved `DataTag` to `components/Api` (#5317)

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Shanmughapriyan S <[email protected]>

* hot-fix: dependency updates and fix dev runtime

* chore: updated start command

* migration(Layout): newFooter (#5320)

Co-authored-by: Claudio Wunder <[email protected]>

* feat: migrate EditLink component (#5271)

Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* feat(blog) Migrate BlogCard component (#5323)

Co-authored-by: Michael Esteban <[email protected]>

* Issue#5307 - Add framer-motion to the dependency list (#5318)

* chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <[email protected]>

* chore: add remote turbo cache and simplified gh actions cache

* chore: updated cache rules

* chore: more cache rules

---------

Co-authored-by: Aymen Naghmouchi <[email protected]>

* chore: fix storybook local development mode (#5335)

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <[email protected]>

* chore: migrate releases types (#5324)

* hotfix: first element no margin-top

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* chore: updated dependencies

* chore: vercel enable middleware and i18n redirection (#5300)

* feat(unit-test): introduce unit test on website redesign branch (#5178

feat(unit-test): introduce unit test

* chore: set up storybook (#5191) (#5214)

* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)

* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)

Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>

* chore: fix storybook styles, imports, typescript config and dependencies (#5319

* chore: optimises tsconfig

* chiore: add missing dependencies

* chore: type storybook constants

* chore: styles moved styles to somewhere else

* chore: add global json type definition

* chore: i18n aria-label instead of sr-only

* chore: added open sans font family and space between imports

* chore: moved styles and fixed styles and updated banner stories

* fix: stylelint rules

* chore: updated tsconfig

* chore: fix tests

* fix: darkmodetoggle test

* chore: stories use index.stories.tsx

* chore: adopt turborepo (#5316

* chore: revert pnpm use plain npm

* fix: package.json

* chore: remove warnings and add node_env

* chore: cross-env

* fix: fix turbo pipelines

* chore: only cache certain files

* chore: turbo shouldn't care about coverage outputs

* chore: proper inputs and outputs for pipelines

* chore: do not store some outputs and updated inputs for lint

* chore: added prettier configs

* chore: remove console.info

* chore: updated inputs of all other entries

* feat(stability): migrate component

* chore(snapshot): update

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fea(stability): update stories + fix

* Update components/Api/Stability/index.stories.tsx

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix(i18n): update turkish language direction (#5182)

* chore: rollback CODEOWNER changes (#5183)

* Sync: merge `major/website-redesign` into `main` (#5356)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>

* feat(stability): update snapshot

* Update components/Api/Stability/index.tsx

Co-authored-by: Jithil P Ponnan <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* code format

* Update components/Api/Stability/index.tsx

Co-authored-by: Jithil P Ponnan <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

---------

Signed-off-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Jatin <[email protected]>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jithil P Ponnan <[email protected]>
ovflowd added a commit that referenced this pull request May 18, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <[email protected]>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <[email protected]>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <[email protected]>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <[email protected]>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <[email protected]>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <[email protected]>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants