chore(migration): migrate language selector component #5266

ktssr · 2023-04-13T10:05:00Z

No description provided.

ovflowd · 2023-04-13T12:02:03Z

Hey @ktssr could you rebase your PR?

ovflowd · 2023-04-13T12:32:19Z

I would recommend checking out the major/website-redesign branch again, creating a new clean branch and just cherry-picking these commits. (Except for the merge commit)

ovflowd

The code looks nice :)

I see you also made the Dropdown component, but it seems a more straightforward version from this.

Does it still work as intended? If yes, that's great :)

Anyhow, outstanding first contribution! (FYI: I left a few comments that can be addressed)

components/Common/Dropdown/__tests__/index.test.tsx

components/Common/Dropdown/index.stories.tsx

components/Common/Dropdown/index.tsx

components/Common/LanguageSelector/index.stories.tsx

package.json

…ector

Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: ktssr <[email protected]>

ovflowd

Really good stuff! I left a few comments but pretty much we're almost there!

components/Common/Dropdown/index.tsx

components/Common/LanguageSelector/__tests__/index.test.tsx

components/Common/LanguageSelector/index.tsx

ovflowd

Nice. Ready to get merged! cc @nodejs/website let's get the reviews/approvals!

…ector

vercel · 2023-04-19T18:19:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 20, 2023 5:07am
nodejs-org-stories	✅ Ready (Inspect)	Visit Preview		Apr 20, 2023 5:07am
nodejs-org-storybook	✅ Ready (Inspect)	Visit Preview		Apr 20, 2023 5:07am

ovflowd · 2023-04-19T18:32:14Z

ngl (not gonna lie), I love these deployments.

…ector

mikeesto

Thanks for your first contribution

Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>

* feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore(minor): just a tiny design nitpick * chore: set up storybook (#5191) (#5214) * chore: set up testing-library jest extend (#5231) Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore(dependencies): updated dependencies * feat: create section title component (#5237) Co-authored-by: Wai.Tung <[email protected]> * 📎 chore(migration): migrate banner component (#5233) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate AnimatedPlaceholder component (#5238 Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story. * feat: create article alert component (#5243) * feat: migrate blockquote component (#5259) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat: create article data tag component (#5280) * feat: migrate AuthorList component and add story 🎉 (#5277) Co-authored-by: Michael Esteban <[email protected]> * chore(migration): migrate language selector component (#5266) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: contributing quick fix of example Signed-off-by: Claudio Wunder <[email protected]> * chore: story guide and react spreading Signed-off-by: Claudio Wunder <[email protected]> * chore: remove base styles from old styling * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * fix(package.json) Lint command is missing slashes (#5321 fix(package.json) lint:fix missing slashes * moved `DataTag` to `components/Api` (#5317) Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <[email protected]> * hot-fix: dependency updates and fix dev runtime * chore: updated start command * migration(Layout): newFooter (#5320) Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate EditLink component (#5271) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * feat(blog) Migrate BlogCard component (#5323) Co-authored-by: Michael Esteban <[email protected]> * Issue#5307 - Add framer-motion to the dependency list (#5318) * chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: add remote turbo cache and simplified gh actions cache * chore: updated cache rules * chore: more cache rules --------- Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: fix storybook local development mode (#5335) * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <[email protected]> * chore: migrate releases types (#5324) * hotfix: first element no margin-top * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated dependencies * chore: vercel enable middleware and i18n redirection (#5300) * feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore: set up storybook (#5191) (#5214) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * feat(stability): migrate component * chore(snapshot): update * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fea(stability): update stories + fix * Update components/Api/Stability/index.stories.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix(i18n): update turkish language direction (#5182) * chore: rollback CODEOWNER changes (#5183) * Sync: merge `major/website-redesign` into `main` (#5356) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> * feat(stability): update snapshot * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * code format * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> --------- Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Jatin <[email protected]> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Yagiz Nizipli <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jithil P Ponnan <[email protected]>

ktssr requested a review from a team as a code owner April 13, 2023 10:05

ktssr mentioned this pull request Apr 13, 2023

Migrate CommonComponents from nodejs.dev #5193

Closed

8 tasks

ktssr force-pushed the chore/migrate-language-selector branch from e1aba71 to d4856a1 Compare April 13, 2023 12:43

ovflowd approved these changes Apr 15, 2023

View reviewed changes

ovflowd force-pushed the major/website-redesign branch from 5cdab56 to 0240b9b Compare April 15, 2023 08:17

Teja Sai Sandeep Reddy Konala added 3 commits April 15, 2023 10:24

chore(migration):lnaguage selector

cdcda64

refactor(code): format and conventions

1cd780c

fix(build): adding missing dependencies

8ca96b6

ovflowd force-pushed the chore/migrate-language-selector branch from e5cf37d to 8ca96b6 Compare April 15, 2023 08:24

shanpriyan added the website redesign Issue/PR part of the Node.js Website Redesign label Apr 15, 2023

shanpriyan and others added 4 commits April 16, 2023 00:18

Merge branch 'major/website-redesign' into chore/migrate-language-sel…

e4f8d1a

…ector

Update components/Common/Dropdown/__tests__/index.test.tsx

d4b693f

Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: ktssr <[email protected]>

Update components/Common/Dropdown/index.tsx

038259a

Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: ktssr <[email protected]>

fix(PR review comments): migrate language selector component

892b1ab

ovflowd approved these changes Apr 19, 2023

View reviewed changes

Teja Sai Sandeep Reddy Konala added 3 commits April 19, 2023 13:46

fix(PR review comments): migrate language selector component

21994ef

fix(PR review comments): migrate language selector component

1a43391

fix(PR review comments): migrate language selector component

ebd0058

ovflowd approved these changes Apr 19, 2023

View reviewed changes

Teja Sai Sandeep Reddy Konala and others added 2 commits April 19, 2023 16:55

fix(lint): css properties order corrected

93999aa

Merge branch 'major/website-redesign' into chore/migrate-language-sel…

7a240d9

…ector

vercel bot temporarily deployed to Preview – nodejs-org April 19, 2023 18:21 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-storybook April 19, 2023 18:23 Inactive

Merge branch 'major/website-redesign' into chore/migrate-language-sel…

5cf730f

…ector

vercel bot temporarily deployed to Preview – nodejs-org April 20, 2023 05:06 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories April 20, 2023 05:07 Inactive

mikeesto approved these changes Apr 20, 2023

View reviewed changes

aymen94 approved these changes Apr 20, 2023

View reviewed changes

ovflowd merged commit 79b5134 into nodejs:major/website-redesign Apr 20, 2023

Uh oh!

chore(migration): migrate language selector component #5266

chore(migration): migrate language selector component #5266

Uh oh!

Conversation

ktssr commented Apr 13, 2023

Uh oh!

ovflowd commented Apr 13, 2023

Uh oh!

ovflowd commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Apr 19, 2023

Uh oh!

mikeesto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ovflowd commented Apr 13, 2023 •

edited

Loading

ovflowd left a comment •

edited

Loading

vercel bot commented Apr 19, 2023 •

edited

Loading