Skip to content

Add query to retrieve adapter handle from platform. #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add query to retrieve adapter handle from platform. #2365

merged 1 commit into from
Dec 17, 2024

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 21, 2024 •
edited
Loading

Fixes #1157

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Nov 21, 2024
@aarongreig aarongreig force-pushed the aaron/addAdapterPlatformQuery branch 2 times, most recently from 07d446f to 366a16b Compare November 21, 2024 15:48
@aarongreig aarongreig force-pushed the aaron/addAdapterPlatformQuery branch from 366a16b to c67d128 Compare November 29, 2024 11:50
@aarongreig aarongreig marked this pull request as ready for review November 29, 2024 11:53
@aarongreig aarongreig requested review from a team as code owners November 29, 2024 11:53
@aarongreig aarongreig requested a review from Seanst98 November 29, 2024 11:53
@aarongreig
Copy link
Contributor Author

LLVM PR intel/llvm#16214

nrspruit
nrspruit approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0 changes LGTM

@aarongreig
Copy link
Contributor Author

ping @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write

@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Dec 16, 2024
@kbenzie kbenzie merged commit c36a0b6 into oneapi-src:main Dec 17, 2024
73 of 74 checks passed
@kbenzie kbenzie mentioned this pull request Dec 18, 2024
Closed
martygrant added a commit to intel/llvm that referenced this pull request Dec 18, 2024
@martygrant
[UR] Update tag to d18d523 for the following PRs:
fa1667e 
- oneapi-src/unified-runtime#2415
- oneapi-src/unified-runtime#2477
- oneapi-src/unified-runtime#2474
- oneapi-src/unified-runtime#2472
- oneapi-src/unified-runtime#1332
- oneapi-src/unified-runtime#2365
- oneapi-src/unified-runtime#2376
@martygrant martygrant mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

@hvdijk hvdijk hvdijk approved these changes

@nrspruit nrspruit nrspruit approved these changes

@Seanst98 Seanst98 Awaiting requested review from Seanst98 Seanst98 was automatically assigned from oneapi-src/unified-runtime-hip-write

+1 more reviewer

@kbenzie kbenzie kbenzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider adding UR_PLATFORM_INFO_ADAPTER to ur_platform_info_t

5 participants

@aarongreig @frasercrmck @hvdijk @kbenzie @nrspruit