[L0] For 3-Channel memory, disable Copy engine Usage #2472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Dec 16, 2024
nrspruit
commented
- Due to limitations on certain systems, disable the usage of copy engines given 3-channel memory
- Currently only bindless requires this check due to 3-channel only being used in bindless and copy engine disabled by default in enqueueMemImageCommandHelper.
aravindksg
approved these changes
Dec 16, 2024
- Due to limitations on certain systems, disable the usage of copy engines given 3-channel memory - Currently only bindless requires this check due to 3-channel only being used in bindless and copy engine disabled by default in enqueueMemImageCommandHelper. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_3_channel_bindless
branch
from
15240b0 to
123e139
Compare
|
@oneapi-src/unified-runtime-bindless-images-write , please review such that we can fix this issue with copy engine usage for 3-channel given the known limitations. |
wenju-he
reviewed
Dec 17, 2024
Co-authored-by: Wenju He <[email protected]>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 17, 2024
-pre-commit PR for oneapi-src/unified-runtime#2472 Signed-off-by: Neil R. Spruit <[email protected]>
|
Updated with @wenju-he suggestion. |
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 18, 2024
kbenzie
pushed a commit
that referenced
this pull request
Dec 19, 2024
[L0] For 3-Channel memory, disable Copy engine Usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.