[L0] Fix use after free with Module build strings #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Dec 17, 2024
nrspruit
commented
- Address Sanitizer HASAN fails with temporary strings even after last use after free patch. This change resolves all use after free of these strings satifsying the address sanitzer checks with HASAN.
- Address Sanitizer HASAN fails with temporary strings even after last use after free patch. This change resolves all use after free of these strings satifsying the address sanitzer checks with HASAN. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_use_after_free_build_strings
branch
from
22b56d7 to
3973136
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 17, 2024
-pre-commit PR for oneapi-src/unified-runtime#2474 Signed-off-by: Neil R. Spruit <[email protected]>
pbalcer
approved these changes
Dec 17, 2024
|
The CI in the intel/llvm patch is working, the multi device CI is hung until the systems are rebooted. |
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 18, 2024
kbenzie
pushed a commit
that referenced
this pull request
Dec 19, 2024
[L0] Fix use after free with Module build strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.