[pull] swiftwasm from main #2241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to ConcurrentReadableHashMap. rdar://problem/70220804
For non-asserts builds, this would produce the wrong result. Simply return from the function instead (as we do in the case where we expect this to be handled).
…he async convention The function can then be implemented in the runtime. Note: This is a temporary hack.
Tests that need to execute need to be marked as such so they can be skipped in platforms that are cross-compiled and do not have a target platform available. This situation happens in the Android CI machines. Introduced in swiftlang#34746.
Seems that Windows uses TMP and TEMP (more details about why two in https://devblogs.microsoft.com/oldnewthing/20150417-00/?p=44213), but doesn't seem to use TMPDIR at all. The changes set all three to the same value. I am not removing TMPDIR just in case. It seems to avoid creating files in the other temporal directories for the compilation and testing. This temp directory should be clean up by the CI machines when recreating the new working directory for the next build. Let's hope we can stop having to babysit the CI servers every month.
swift-ide-test -batch-code-completion has no particular order for the output completion list. Update the order dependent tests to use DAG instead.
…UninitializedInst::get{,MarkUninitialized}Kind().
Interestingly this problem can only occur if one invokes
MarkUninitializedInst::getKind() directly. Once our instruction is just a
SILInstruction, we call the appropriate method so we didn't notice it.
I used Xcode's refactoring functionality to find all of the invocation
locations.
When mirroring declarations from protocols, make sure to mirror for all potential imported names. Otherwise, we might miss out on one or the other of an async import or a completion-handler import of the same method. Fixes rdar://71429577.
The previous change was too broad and caused several regressions.
@asyncHandler is currently unimplemented in SILGen, and will cause SIL verifier assertions if used. Rather than trigger assertions, emit a trap for the body. Obviously, this is a temporary hack.
[Concurrency] Emit @asyncHandler bodies as traps.
…-mirrored-protocols [Clang importer] Make sure we mirror protocol decls for all names.
Demangling: avoid implicit fallthrough
…nd-tmpdir [windows] Set TMP and TEMP, as well as TMPDIR.
…ires-executable [android] Mark Interpreter/async as an executable test.
The mutating collection subscript for discontiguous slices assigns to the wrong group of indices. This fixes the behavior and adds test coverage. rdar://problem/70690643
The new implementation has been the default for a while now and seems to be stable and relatively bug-free.
[Serialization] Fix crashes when allowing compiler errors in modules
…c6129e100c7aa7c374d4fa7
[sil] Element shadowing of SILInstruction::getKind() by renaming MarkUninitializedInst::get{,MarkUninitialized}Kind().
…gen_name IRGen: Allow calling a pre-defined async silgen_name function using the async convention
…-concurrentreadablehashmap [Runtime] Change ProtocolCache, NominalCache, and HashableConformances to ConcurrentReadableHashMap.
[Gardening] Fix up order-dependent batch code complete tests
kateinoigakukun
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )