Skip to content

Add close action to modal body block #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

Add close action to modal body block #3334

wants to merge 28 commits into from

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Oct 28, 2025

📌 Summary

If merged, this PR yields the close action to the modal body block.

🛠️ Detailed description

TBD

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

zamoore and others added 20 commits October 28, 2025 15:15
@zamoore
init commit
ccfc247
@zamoore
HdsAdvancedTableTh Remove @isVisuallyHidden argument (#3210)
8c0269d
@zamoore
Fix service import deprecation (#3181)
14d7e3a
@zamoore
Remove deprecated HdsMenuPrimitive component (#3224)
1968a74
@zamoore
Remove unneeded sass-related dependencies (#3206)
8ae5fe6
@zamoore
HdsDropdownListItemInteractive - Remove deprecated @text argument (…
7677374 
…#3212)
@zamoore
HdsSideNav deprecations (#3230)
8cfc57b
@zamoore
Update ember-try matrix (#3202)
6240c1f
@zamoore @RobbieTheWagner
Update Ember version compatibility (#3264)
5eb8933 
Co-authored-by: Robbie Wagner <[email protected]>
@zamoore
Deprecate HdsModal and HdsFlyout yielded subcomponents (#3222)
bb041a6
@zamoore
Remove deprecated ember-flight-icon lazyEmbed flag (#3272)
2494fae
@hashibot-hds @jorytindall @zamoore
Updated export of icons from Figma (#3269)
9911c57 
Co-authored-by: jorytindall <[email protected]>
Co-authored-by: Jory Tindall <[email protected]>
@zamoore
Add changeset for volume-2 icon rename (#3276)
48a8d74
@zamoore @didoo
ApplicationState - Remove center alignment rule (#3205)
6b244e3 
Co-authored-by: Cristiano Rastelli <[email protected]>
@zamoore
Remove incorrect HdsCard invocation path (#3275)
05b9e81
@shleewhite @aklkv @zamoore
Upgrade ember-a11y-refocus to v5.1.0 (#3234)
8e67949 
Co-authored-by: shleewhite <[email protected]>
Co-authored-by: Alexey Kulakov <[email protected]>
@zamoore
Upgrade ember-stargate (#3268)
7f85840
@zamoore @alex-ju
Add ember-basic-dropdown as a peer dependency (#3282)
156a502 
Co-authored-by: Alex <[email protected]>
@zamoore
Upgrade @ember/render-modifiers (#3294)
d8150f4
@zamoore
Adds a11y guardrails in Dropdown ToggleIcon component
3cf60b9
@vercel
Copy link

vercel bot commented Oct 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 30, 2025 5:33pm
hds-website Ready Ready Preview Oct 30, 2025 5:33pm

@zamoore zamoore force-pushed the yield-close-modal-body branch from 0cf941c to fd986c5 Compare October 29, 2025 15:39
@zamoore zamoore added the release-candidate Publishes release candidates to npm label Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025 •
edited
Loading

📦 RC Packages Published

Latest commit: 1fbc87d

Published 3 packages

@hashicorp/[email protected]

yarn up -C @hashicorp/design-system-codemods@rc

@hashicorp/[email protected]

yarn up -C @hashicorp/design-system-components@rc

@hashicorp/[email protected]

yarn up -C @hashicorp/flight-icons@rc

@zamoore zamoore removed the release-candidate Publishes release candidates to npm label Oct 31, 2025
@zamoore zamoore closed this Oct 31, 2025
@zamoore zamoore deleted the yield-close-modal-body branch October 31, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages/components showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zamoore @hashibot-hds @shleewhite