[FRONTEND][TENSORFLOW] Support Unstack and Split #2105

alexeyr · 2018-11-14T13:10:13Z

No description provided.

alexeyr · 2018-11-16T08:29:30Z

Test failure should be spurious: the same test failed for other pull requests submitted at similar time, including a doc fix.

Rasterer · 2018-11-16T09:48:02Z

nnvm/python/nnvm/frontend/tensorflow.py

+                        if len(outputs) > 1:
+                            tvm_n = tvm_n[num_layer]
+                        inputs.append(tvm_n)
+                        input_shapes[tvm_n] = self._output_shapes[i]


Should it be the following for multiple outputs cases?
input_shapes[tvm_n] = (self._output_shapes[i])[num_layer]

Yes, I think so. I've added a commit which fixes this, but discovered a problem while trying to create a test case distinguishing them.

alexeyr · 2018-11-16T12:55:59Z

I've run into an issue when extending test for unstack. It boils down to this difference:

In Tensorflow,

In [30]: tf.squeeze(tf.placeholder("int32", [1]),0).shape
Out[30]: TensorShape([])

But in TVM,

In [31]: topi.squeeze(tvm.placeholder((1,)),0).shape
Out[31]: [1]

The expected result of squeeze is to drop by one dimension, but in this case it doesn't.
So when I tried to test tf.stack(tf.unstack(in_data, axis=0), axis=0) where in_data has shape (6,), Tensorflow gives the expected result but TVM gives result of shape (6,1).

So, does NNVM support representing scalars with shape () instead of (1,)? I tried to use split_item[0] in d275972#diff-3845514369cc735d96dd63a274a21471R815, but that doesn't work (and I realize it shouldn't, it gets the first output instead of indexing).

Two alternatives if that can't be done:

Error when trying to unstack or squeeze 1d tensors (or later when a shape mismatch is detected).
Mark them with an attribute indicating they "should" be () and handle it in _pack and _expand_dims (do any other operators need it?)

What's best to do here?

alexeyr · 2018-11-21T13:08:22Z

The problem should be fixed now. @srkreddy1238 @siju-samuel seem to be most familiar with this frontend, please review.

alexeyr · 2018-11-22T14:33:30Z

Rebased on master.

srkreddy1238 · 2018-12-05T15:48:58Z

@alexeyr I see two open PR's for Split (other #2123 ).
To give an equal opportunity can you add SplitV and unstack on top of #2123 ?

alexeyr · 2018-12-05T17:16:49Z

By rebasing on top on it? OK, will do tomorrow.

alexeyr · 2018-12-06T09:15:03Z

@srkreddy1238 Done.

srkreddy1238 · 2018-12-07T02:53:05Z

@alexeyr pls rebase against latest master.

alexeyr · 2018-12-07T09:13:07Z

@srkreddy1238 Rebased.

srkreddy1238

@alexeyr thanks. Just a cosmetic change otherwise LGTM.

nnvm/python/nnvm/frontend/tensorflow.py

srkreddy1238

LGTM.

tqchen · 2018-12-13T18:22:25Z

Thanks, @srkreddy1238 @alexeyr , this is merged

commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments

…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments

alexeyr force-pushed the extend_from_tensorflow branch 2 times, most recently from 03fb265 to 76f4651 Compare November 14, 2018 13:40

This was referenced Nov 16, 2018

Add Split and realdiv op support #2123

Merged

[FRONTEND][TENSPRFLOW] Add split support #2001

Closed

Rasterer reviewed Nov 16, 2018

View reviewed changes

alexeyr changed the title ~~[FRONTEND][TENSORFLOW] Support Unstack and Split~~ [WIP][FRONTEND][TENSORFLOW] Support Unstack and Split Nov 16, 2018

alexeyr force-pushed the extend_from_tensorflow branch from d275972 to c350a95 Compare November 21, 2018 11:20

alexeyr changed the title ~~[WIP][FRONTEND][TENSORFLOW] Support Unstack and Split~~ [FRONTEND][TENSORFLOW] Support Unstack and Split Nov 21, 2018

alexeyr force-pushed the extend_from_tensorflow branch 3 times, most recently from 79dd4e2 to 60c9e25 Compare November 21, 2018 11:40

alexeyr mentioned this pull request Nov 22, 2018

[TOPI] Fix atlest1d for reduce and squeeze #2147

Merged

alexeyr force-pushed the extend_from_tensorflow branch from 60c9e25 to 785b082 Compare November 22, 2018 14:22

yzhliu added the status: need review label Nov 26, 2018

alexeyr force-pushed the extend_from_tensorflow branch 2 times, most recently from b178471 to 37bf662 Compare December 5, 2018 08:12

alexeyr force-pushed the extend_from_tensorflow branch 3 times, most recently from 69029a9 to 0003a35 Compare December 6, 2018 09:09

alexeyr force-pushed the extend_from_tensorflow branch from 0003a35 to de8da06 Compare December 6, 2018 09:30

alexeyr mentioned this pull request Dec 6, 2018

[FRONTEND][TENSORFLOW] Simplify input shape #2242

Merged

alexeyr force-pushed the extend_from_tensorflow branch from de8da06 to 388bb44 Compare December 7, 2018 09:12

srkreddy1238 requested changes Dec 10, 2018

View reviewed changes

nnvm/python/nnvm/frontend/tensorflow.py Outdated Show resolved Hide resolved

yzhliu added the status: need update need update based on feedbacks label Dec 11, 2018

alexeyr force-pushed the extend_from_tensorflow branch from 388bb44 to c3327a5 Compare December 12, 2018 07:08

alexeyr added 2 commits December 12, 2018 10:17

[FRONTEND][TENSORFLOW] Support Unstack and SplitV

633ceed

Fix for stack(unstack(data)) != data

c3327a5

srkreddy1238 approved these changes Dec 13, 2018

View reviewed changes

tqchen merged commit 00d509d into apache:master Dec 13, 2018

tqchen added status: accepted and removed status: need review status: need update need update based on feedbacks labels Dec 13, 2018

FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018

[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

85dca0f

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

6c2334a

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

998cb89

srkreddy1238 mentioned this pull request Mar 9, 2019

[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. #2757

Merged

[FRONTEND][TENSORFLOW] Support Unstack and Split #2105

[FRONTEND][TENSORFLOW] Support Unstack and Split #2105

Uh oh!

Conversation

alexeyr commented Nov 14, 2018

Uh oh!

alexeyr commented Nov 16, 2018

Uh oh!

Rasterer Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

alexeyr Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

alexeyr commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeyr commented Nov 21, 2018

Uh oh!

alexeyr commented Nov 22, 2018

Uh oh!

srkreddy1238 commented Dec 5, 2018

Uh oh!

alexeyr commented Dec 5, 2018

Uh oh!

alexeyr commented Dec 6, 2018

Uh oh!

srkreddy1238 commented Dec 7, 2018

Uh oh!

alexeyr commented Dec 7, 2018

Uh oh!

srkreddy1238 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srkreddy1238 left a comment

Choose a reason for hiding this comment

Uh oh!

tqchen commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexeyr commented Nov 16, 2018 •

edited

Loading