[FRONTEND][TENSORFLOW] Bugfix #2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkreddy1238
requested changes
Dec 23, 2018
| pass | ||
| else: | ||
| final_output.append(out_shape[gather_index]) | ||
| # Prevent 0-dim tensors which are not accepted by nnvm |
Contributor
There was a problem hiding this comment.
@dominicsymes thanks for the change.
Please add a test case for this.
Contributor
Author
There was a problem hiding this comment.
@srkreddy1238 thanks for taking a look.
I have added a test case that triggers strided slice with 0-dim output.
srkreddy1238
approved these changes
Dec 24, 2018
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
Thanks @dominicsymes . LGTM.
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Closed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
srkreddy1238
added a commit
to srkreddy1238/tvm
that referenced
this pull request
Mar 9, 2019
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
srkreddy1238
added a commit
to srkreddy1238/tvm
that referenced
this pull request
Mar 9, 2019
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
srkreddy1238
added a commit
to srkreddy1238/tvm
that referenced
this pull request
Mar 9, 2019
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
srkreddy1238
added a commit
to srkreddy1238/tvm
that referenced
this pull request
Mar 11, 2019
commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
srkreddy1238
added a commit
to srkreddy1238/tvm
that referenced
this pull request
Mar 12, 2019
commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
srkreddy1238
added a commit
that referenced
this pull request
Mar 19, 2019
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Mar 20, 2019
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 20, 2019
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I noticed a couple of problems while compiling an example with the tensorflow frontend module. The two small changes in the attached commit seem to fix the issues. One change is a simple rename of a dummy variable which was clashing with the function argument 'shape'. The second is to deal with the case of when a shrink axis operator produces a tensor with dimension zero - this does not seem to work with nnvm where the dimension must be at least one. I'd welcome any comments - particularly on whether this is the correct way to deal with the 0-dim result. Thanks.