Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 13, 2018

Support for tf.image.crop_to_bounding_box in tensorflow frontend.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@srkreddy1238
Copy link
Contributor

@ashutoshparkhi suggest to raise another PR for dlpack changes.

@icemelon icemelon added the status: need update need update based on feedbacks label Jan 5, 2019
@srkreddy1238
Copy link
Contributor

@ashutoshparkhi can you act on the review comments ?

@ghost
Copy link
Author

ghost commented Jan 14, 2019

@icemelon9 and @srkreddy1238 updated the PR with the requested changes. Thanks!

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ashutoshparkhi

@srkreddy1238 srkreddy1238 merged commit 6737739 into apache:master Jan 14, 2019
@ghost
Copy link
Author

ghost commented Jan 14, 2019

Thanks @srkreddy1238 for the review.

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
commit f347b52
Author: Yong Wu <[email protected]>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <[email protected]>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <[email protected]>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <[email protected]>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <[email protected]>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <[email protected]>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
commit f347b52
Author: Yong Wu <[email protected]>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <[email protected]>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <[email protected]>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <[email protected]>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <[email protected]>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <[email protected]>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
commit f347b52
Author: Yong Wu <[email protected]>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <[email protected]>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <[email protected]>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <[email protected]>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <[email protected]>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <[email protected]>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <[email protected]>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <[email protected]>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
@ghost ghost deleted the crop branch March 11, 2019 10:25
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 11, 2019
commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 12, 2019
commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit that referenced this pull request Mar 19, 2019
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (#2444)

commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (#2285)

commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242)

commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (#2326)

commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (#2105)

commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (#2267)

commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
…che#2757)

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
…che#2757)

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva [email protected]
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi [email protected]
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov [email protected]
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva [email protected]
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin [email protected]
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need update need update based on feedbacks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants