-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[FRONTEND][TENSORFLOW] Simplify input shape #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRONTEND][TENSORFLOW] Simplify input shape #2242
Conversation
|
This gives some warnings when running tests, like
and
I guess the second should be fixed by modifying AutoTVM lookup, but I don't know about the first. |
a5738b7 to
23a10d3
Compare
|
@alexeyr Could you resolve the conflicts to latest master? |
|
@alexeyr changes related to Unstack and Split(V) are already merged. |
23a10d3 to
d641aee
Compare
|
@icemelon9 Updated. |
|
@srkreddy1238 Yes, this pull request doesn't fix any bugs, it is intended to simplify code while producing the exact same result. I've now verified that it actually does that: I get the
and other warnings when running the tests from IPython on the first try and don't get them after repeating. This happens both in I also saved JSON of all graphs produced by Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexeyr Thanks. LGTM.
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
commit f347b52 Author: Yong Wu <[email protected]> Get tags of saved model automatically commit 916576c Author: Zhi Chen <[email protected]> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <[email protected]> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <[email protected]> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <[email protected]> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <[email protected]> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <[email protected]> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <[email protected]> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva [email protected] [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi [email protected] [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov [email protected] [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva [email protected] [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin [email protected] [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.
Depends on #2105.