Skip to content

Conversation

@fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Sep 9, 2021

2709 runtime tests were enabled to run with iOSSimulator x64.

@ghost
Copy link

ghost commented Sep 9, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@fanyang-mono fanyang-mono force-pushed the enable_ios_CustomCommand branch from a76b5f7 to b4e85a1 Compare September 13, 2021 16:01
@fanyang-mono
Copy link
Member Author

This PR can only be merged, after #58999 being merged. And an Arcade issue was exposed by the iOSSimulator run dotnet/arcade#7900, which I don't think is a blocker for this PR, however, @premun was a little worried and would like to fix it before merging this PR.

@fanyang-mono
Copy link
Member Author

Currently, I am working on disabling failed tests and long running tests on iOSSimulator to get the lane green.

@fanyang-mono fanyang-mono force-pushed the enable_ios_CustomCommand branch from 5fc8bc7 to e6ee98f Compare September 17, 2021 18:13
@premun premun force-pushed the enable_ios_CustomCommand branch from e6ee98f to 423565d Compare September 20, 2021 15:19
@fanyang-mono fanyang-mono marked this pull request as ready for review September 20, 2021 15:46
@fanyang-mono fanyang-mono requested a review from trylek September 20, 2021 15:47
@fanyang-mono
Copy link
Member Author

@trylek Some work items took too long to finish when running on iOS Simulator. Therefore, I further split them. So far, they are JIT.Regression, JIT.HardwareIntrinsics and JIT. I'd like to get your opinion on the corresponding change. :)

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the test groups looks good to me but I would prefer someone more familiar with Mono to review the Mono-specific changes. Am I right to understand that commenting out parts of the YAML scripts is just instrumentation you're using to speed up your testing inner loop and will be reverted before merging in?

@fanyang-mono
Copy link
Member Author

Splitting the test groups looks good to me but I would prefer someone more familiar with Mono to review the Mono-specific changes. Am I right to understand that commenting out parts of the YAML scripts is just instrumentation you're using to speed up your testing inner loop and will be reverted before merging in?

Thanks for reviewing. The mono-specific changes will be reviewed by Premek. He is very familiar with those change. Yes, the YAML scripts change will be reverted before merging.

@fanyang-mono
Copy link
Member Author

fanyang-mono commented Sep 22, 2021

Currently, runtime tests are failing randomly on iOS Simulator. And I can't see the failure logs without the fix to dotnet/arcade#7900. @premun just got it fixed this morning, and he will bump the arcade version for my PR tmr.

@fanyang-mono fanyang-mono added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 22, 2021
@premun premun force-pushed the enable_ios_CustomCommand branch 2 times, most recently from e03d666 to 7854cfc Compare September 23, 2021 08:22
@fanyang-mono
Copy link
Member Author

fanyang-mono commented Sep 23, 2021

After fixing dotnet/arcade#7900, somehow the test logs were all gone. I created a new issue for @premun to investigate (dotnet/arcade#7943).

Yesterday, XHarness Telemetry was enabled in this PR, @premun got more insight data. He noticed that the app installation on some machines from yesterday's run could take more than 30 minutes. He is working on a work around for it (dotnet/arcade#7944). Once that's fixed, we should be able to see more stable run times. He's aiming at getting that change in either the end of this week or early next week.

Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please bump XHarness and Arcade in your branch again?

The new Arcade will soon be in main but meanwhile you can call:

darc update-dependencies --source-repo=dotnet/arcade --channel ".NET Eng - Latest"

and

darc update-dependencies --source-repo=dotnet/xharness --channel ".NET Eng - Latest"

@premun
Copy link
Member

premun commented Oct 15, 2021

@fanyang-mono can we merge main in this PR and test whether the logs are showing now?

@fanyang-mono fanyang-mono force-pushed the enable_ios_CustomCommand branch from 3029c5f to 83fbd60 Compare October 22, 2021 15:17
@fanyang-mono fanyang-mono changed the title Use XHarnessAppBundleToTest to create helix work items when runtime tests run on iOS and tvOS Use XHarnessAppBundleToTest to create helix work items when runtime tests run on iOSSimulator Oct 22, 2021
@fanyang-mono fanyang-mono removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 22, 2021
@premun premun merged commit fbb109c into dotnet:main Oct 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants