- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
Use XHarnessAppBundleToTest to create helix work items when runtime tests run on iOSSimulator #58870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. | 
a558b33    to
    a31c07d      
    Compare
  
    a76b5f7    to
    b4e85a1      
    Compare
  
    | This PR can only be merged, after #58999 being merged. And an Arcade issue was exposed by the iOSSimulator run dotnet/arcade#7900, which I don't think is a blocker for this PR, however, @premun was a little worried and would like to fix it before merging this PR. | 
| Currently, I am working on disabling failed tests and long running tests on iOSSimulator to get the lane green. | 
5fc8bc7    to
    e6ee98f      
    Compare
  
    e6ee98f    to
    423565d      
    Compare
  
    | @trylek Some work items took too long to finish when running on iOS Simulator. Therefore, I further split them. So far, they are JIT.Regression, JIT.HardwareIntrinsics and JIT. I'd like to get your opinion on the corresponding change. :) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting the test groups looks good to me but I would prefer someone more familiar with Mono to review the Mono-specific changes. Am I right to understand that commenting out parts of the YAML scripts is just instrumentation you're using to speed up your testing inner loop and will be reverted before merging in?
| 
 Thanks for reviewing. The mono-specific changes will be reviewed by Premek. He is very familiar with those change. Yes, the YAML scripts change will be reverted before merging. | 
| Currently, runtime tests are failing randomly on iOS Simulator. And I can't see the failure logs without the fix to dotnet/arcade#7900. @premun just got it fixed this morning, and he will bump the arcade version for my PR tmr. | 
e03d666    to
    7854cfc      
    Compare
  
    | After fixing dotnet/arcade#7900, somehow the test logs were all gone. I created a new issue for @premun to investigate (dotnet/arcade#7943). Yesterday, XHarness Telemetry was enabled in this PR, @premun got more insight data. He noticed that the app installation on some machines from yesterday's run could take more than 30 minutes. He is working on a work around for it (dotnet/arcade#7944). Once that's fixed, we should be able to see more stable run times. He's aiming at getting that change in either the end of this week or early next week. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please bump XHarness and Arcade in your branch again?
The new Arcade will soon be in main but meanwhile you can call:
darc update-dependencies --source-repo=dotnet/arcade --channel ".NET Eng - Latest"
and
darc update-dependencies --source-repo=dotnet/xharness --channel ".NET Eng - Latest"
| @fanyang-mono can we merge main in this PR and test whether the logs are showing now? | 
This reverts commit 48853f49a5c595e3b79351ebd3b7198c5989fc55.
This reverts commit 2b16b107829d73f862d9010ec26b49fc6b8799d0.
3029c5f    to
    83fbd60      
    Compare
  
    
2709 runtime tests were enabled to run with iOSSimulator x64.