Fix logstash-keystore to accept spaces in values when added via stdin #17039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@logstashmachine backport 8.18 |
5 tasks
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17040) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
|
@logstashmachine backport 8.17 |
|
@logstashmachine backport 9.0 |
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17041) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
5 tasks
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17042) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
v1v
pushed a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…elastic#17039) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored.
v1v
added a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…gify * upstream/main: (27 commits) Add Windows 2025 to CI (elastic#17133) Update container acceptance tests with stdout/stderr changes (elastic#17138) entrypoint: avoid polluting stdout (elastic#17125) Fix acceptance test assertions for updated plugin remove (elastic#17126) Fix acceptance test assertions for updated plugin `remove` (elastic#17122) plugins: improve `remove` command to support multiple plugins (elastic#17030) spec: improve ls2ls spec (elastic#17114) allow concurrent Batch deserialization (elastic#17050) CPM handle 404 response gracefully with user-friendly log (elastic#17052) qa: use clean expansion of LS tarball per fixture instance (elastic#17082) Allow capturing heap dumps in DRA BK jobs (elastic#17081) Use centralized source of truth for active branches (elastic#17063) Update logstash_releases.json (elastic#17055) fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039) Don't honor VERSION_QUALIFIER if set but empty (elastic#17032) Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026) Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968) Add short living 9.0 next and update main in CI release version definition. (elastic#17008) Core version bump to 9.1.0 (elastic#16991) Add 9.0 branch to the CI branches definition (elastic#16997) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Fix logstash-keystore to accept spaces in values when added via stdin
What does this PR do?
logstash-keystoreincorrectly handled values containing spaces, causing only the first word to be stored.For example, a value like "Hello, world!" was split, resulting in "Hello," as the stored value instead of the full string.
This commit preserves spaces in values, ensuring that multi-word strings are stored as intended.
Why is it important/What is the impact to the user?
This issue mainly affected ECK users who followed best practices for managing secure settings, leading to incorrect value assignments.
Users who use stdin to add value are impacted as well. For example,
echo "somevalue" | bin/logstash-keystore add helloChecklist
Author's Checklist
How to test this PR locally
it should print "hello world"
Related issues
Use cases
Screenshots
Logs