Skip to content

Fix acceptance test assertions for updated plugin remove #17122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix acceptance test assertions for updated plugin remove #17122

merged 1 commit into from
Feb 19, 2025

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Feb 19, 2025 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.

Why is it important/What is the impact to the user?

No user impact, this is fixing acceptance test assertions

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Logs

Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1359#01951fe3-2f12-46d5-872e-0af111c463ba

1) CLI operation behaves like logstash uninstall logstash-plugin uninstall on [Ubuntu 22.04] when the plugin isn't installed fails to uninstall it
--
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash uninstall" called from ./acceptance/spec/lib/cli_operation_spec.rb:37
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/uninstall.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | 2) CLI operation behaves like logstash remove logstash-plugin remove on [Ubuntu 22.04] when the plugin isn't installed fails to remove it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed" to match /This plugin has not been previously installed/
  | Diff:
  | @@ -1 +1 @@
  | -/This plugin has not been previously installed/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-filter-qatest` has not been previously installed"
  |  
  | Shared Example Group: "logstash remove" called from ./acceptance/spec/lib/cli_operation_spec.rb:38
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/remove.rb:36:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | 3) CLI operation behaves like integration plugins compatible logstash-plugin uninstall on [Ubuntu 22.04] when the integration is installed trying to uninstall an inner plugin fails to uninstall it
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-input-rabbitmq` is provided by 'logstash-integration-rabbitmq' so it can't be removed individually" to match /is already provided by/
  | Diff:
  | @@ -1 +1 @@
  | -/is already provided by/
  | +"ERROR: Operation aborted, cannot remove plugin, message: The plugin `logstash-input-rabbitmq` is provided by 'logstash-integration-rabbitmq' so it can't be removed individually"
  |  
  | Shared Example Group: "integration plugins compatible" called from ./acceptance/spec/lib/cli_operation_spec.rb:40
  | # ./acceptance/spec/shared_examples/cli/logstash-plugin/integration_plugin.rb:78:in `block in <main>'
  | # ./Rakefile:30:in `block in <main>'
  |  
  | Finished in 21 minutes 10 seconds (files took 1.68 seconds to load)
  | 30 examples, 3 failures, 1 pending

@donoghuc
Fix acceptance test assertions for updated plugin remove
e33665d 
This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
@donoghuc donoghuc requested a review from yaauie February 19, 2025 22:29
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

mashhurs
mashhurs approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@mashhurs mashhurs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for taking care.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

yaauie
yaauie approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll merge and kick off backports.

@yaauie yaauie merged commit e094054 into elastic:main Feb 19, 2025
7 checks passed
@yaauie
Copy link
Member

yaauie commented Feb 19, 2025

@logstashmachine backport 9.0

@yaauie
Copy link
Member

yaauie commented Feb 19, 2025

@logstashmachine backport 8.x

github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
@donoghuc @logstashmachine
Fix acceptance test assertions for updated plugin remove (#17122)
f0c56c5 
This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

(cherry picked from commit e094054)
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Merged
1 task
@yaauie
Copy link
Member

yaauie commented Feb 20, 2025

@logstashmachine backport 8.x

yaauie pushed a commit that referenced this pull request Feb 20, 2025
@github-actions @donoghuc
Fix acceptance test assertions for updated plugin remove (#17122) (#…
a86b0ce 
…17123)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.

(cherry picked from commit e094054)

Co-authored-by: Cas Donoghue <[email protected]>
@donoghuc donoghuc mentioned this pull request Feb 20, 2025
Merged
1 task
@github-actions github-actions bot mentioned this pull request Feb 20, 2025
Merged
1 task
@yaauie yaauie mentioned this pull request Feb 20, 2025
Merged
1 task
donoghuc added a commit to donoghuc/logstash that referenced this pull request Feb 20, 2025
@donoghuc
Fix acceptance test assertions for updated plugin remove (elastic#1…
f22e3b0 
…7122)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
donoghuc added a commit that referenced this pull request Feb 21, 2025
@donoghuc
Fix acceptance test assertions for updated plugin remove (#17122) (#…
27a1d43 
…17132)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See #17030
for change.
v1v pushed a commit to v1v/logstash that referenced this pull request Feb 25, 2025
@donoghuc @v1v
Fix acceptance test assertions for updated plugin remove (elastic#1…
3e50919 
…7122)

This commit updates the acceptance tests to expect messages in the updated
format for removing plugins. See elastic#17030
for change.
v1v added a commit to v1v/logstash that referenced this pull request Feb 25, 2025
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-mer…
5b7c095 
…gify

* upstream/main: (27 commits)
  Add Windows 2025 to CI (elastic#17133)
  Update container acceptance tests with stdout/stderr changes (elastic#17138)
  entrypoint: avoid polluting stdout (elastic#17125)
  Fix acceptance test assertions for updated plugin remove (elastic#17126)
  Fix acceptance test assertions for updated plugin `remove` (elastic#17122)
  plugins: improve `remove` command to support multiple plugins (elastic#17030)
  spec: improve ls2ls spec (elastic#17114)
  allow concurrent Batch deserialization (elastic#17050)
  CPM handle 404 response gracefully with user-friendly log (elastic#17052)
  qa: use clean expansion of LS tarball per fixture instance (elastic#17082)
  Allow capturing heap dumps in DRA BK jobs (elastic#17081)
  Use centralized source of truth for active branches (elastic#17063)
  Update logstash_releases.json (elastic#17055)
  fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039)
  Don't honor VERSION_QUALIFIER if set but empty (elastic#17032)
  Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026)
  Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968)
  Add short living 9.0 next and update main in CI release version definition. (elastic#17008)
  Core version bump to 9.1.0 (elastic#16991)
  Add 9.0 branch to the CI branches definition (elastic#16997)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaauie yaauie yaauie approved these changes

@mashhurs mashhurs mashhurs approved these changes

Assignees

No one assigned

Labels

v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@donoghuc @elasticmachine @yaauie @mashhurs