Skip to content

Add Windows 2025 to CI #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

Add Windows 2025 to CI #17133

merged 2 commits into from
Feb 24, 2025

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Feb 20, 2025 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

This commit adds Windows 2025 to the Windows JDK matrix pipeline.

Why is it important/What is the impact to the user?

Is required to satisfy support matrix requirements and ensure the product works on Windows 2025.

How to test this PR locally

Can be tested only in Buildkite. Link:

https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/354

@dliappis
Add Windows 2025 to CI
1bb9795 
This commit adds Windows 2025 to the Windows JDK matrix pipeline.
@dliappis dliappis self-assigned this Feb 20, 2025
@dliappis dliappis added the ci label Feb 20, 2025
@dliappis dliappis requested review from andsel and mashhurs February 20, 2025 18:52
@dliappis dliappis marked this pull request as ready for review February 20, 2025 18:56
mashhurs
mashhurs approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@mashhurs
Copy link
Contributor

Can we run JDK matrix pipeline before merging? - just want to be sure if there is any specific case for Win 2025.

@dliappis
Copy link
Contributor Author

Can we run JDK matrix pipeline before merging? - just want to be sure if there is any specific case for Win 2025.

Ofc its already done, please see the link in the description in the section about testing.
I noticed failures with openjdk 17 (compiler errors) but a) we don't use that as part of our regulars runs b) i think it hasn't been updated for a while (says 17.0.2)

@andsel
Copy link
Contributor

andsel commented Feb 21, 2025

JDK used is 17.0.2+8 https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/354#019524c3-38ee-4124-8725-21ce80b6e5f9/57-75, maybe the JDK installed in the VM image could be updated to 17.0.9+9 in a follow up PR.

andsel
andsel approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis
Also add windows 2025 to the exhaustive suite
dfb876c 
MAke sure that windows 2025 is part of the randomized OS selection
used in exhaustive tests
@dliappis
Copy link
Contributor Author

I noticed that Windows 2025 was missing from the list of OSes used by (randomized) tests in the exhaustive suite, so please take another look.

Triggered two jobs with the latest commit:

  1. Windows JDK matrix: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/355
  2. Exhaustive suite: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1371

@dliappis dliappis requested a review from andsel February 21, 2025 13:19
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

andsel
andsel approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once 🟢 CI, LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @dliappis

@dliappis
Copy link
Contributor Author

@andsel after triggered manually the exhaustive suite using this PR I see the following unrelated failures (unrelated as in they don't run on Windows): https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1371#019528a9-cd2b-477d-91b4-43dd689a31a7/5364-6320

still ok to merge?

@andsel
Copy link
Contributor

andsel commented Feb 21, 2025

Running also on main to check it is unrelated: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1372

@dliappis
Copy link
Contributor Author

Running also on main to check it is unrelated: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1372

same failures on main too, it seems.

@donoghuc
Copy link
Member

Yeah, that is unrelated. Fix incoming here #17138 I think you are G2G with this. Thanks :)

@andsel andsel self-requested a review February 24, 2025 08:55
andsel
andsel approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dliappis LGTM after last changes, the error is not related to this.

@dliappis dliappis merged commit 4d52b72 into elastic:main Feb 24, 2025
7 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 9.0

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.x

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.18

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.17

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.16

github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@dliappis @logstashmachine
Add Windows 2025 to CI (#17133)
2c8c398 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@dliappis @logstashmachine
Add Windows 2025 to CI (#17133)
f02f81c 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@dliappis @logstashmachine
Add Windows 2025 to CI (#17133)
8756d32 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@dliappis @logstashmachine
Add Windows 2025 to CI (#17133)
86adbfd 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@dliappis @logstashmachine
Add Windows 2025 to CI (#17133)
cd54cdb 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
dliappis added a commit that referenced this pull request Feb 24, 2025
@github-actions @dliappis
Add Windows 2025 to CI (#17133) (#17146)
71127fa 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 24, 2025
@github-actions @dliappis
Add Windows 2025 to CI (#17133) (#17142)
574b8ed 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 24, 2025
@github-actions @dliappis
Add Windows 2025 to CI (#17133) (#17144)
7cb800b 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 24, 2025
@github-actions @dliappis
Add Windows 2025 to CI (#17133) (#17145)
bbc80ec 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 24, 2025
@github-actions @dliappis
Add Windows 2025 to CI (#17133) (#17143)
7fec532 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.

(cherry picked from commit 4d52b72)

Co-authored-by: Dimitrios Liappis <[email protected]>
v1v pushed a commit to v1v/logstash that referenced this pull request Feb 25, 2025
@dliappis @v1v
Add Windows 2025 to CI (elastic#17133)
e846feb 
This commit adds Windows 2025 to the Windows JDK matrix and exhaustive tests pipelines.
v1v added a commit to v1v/logstash that referenced this pull request Feb 25, 2025
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-mer…
5b7c095 
…gify

* upstream/main: (27 commits)
  Add Windows 2025 to CI (elastic#17133)
  Update container acceptance tests with stdout/stderr changes (elastic#17138)
  entrypoint: avoid polluting stdout (elastic#17125)
  Fix acceptance test assertions for updated plugin remove (elastic#17126)
  Fix acceptance test assertions for updated plugin `remove` (elastic#17122)
  plugins: improve `remove` command to support multiple plugins (elastic#17030)
  spec: improve ls2ls spec (elastic#17114)
  allow concurrent Batch deserialization (elastic#17050)
  CPM handle 404 response gracefully with user-friendly log (elastic#17052)
  qa: use clean expansion of LS tarball per fixture instance (elastic#17082)
  Allow capturing heap dumps in DRA BK jobs (elastic#17081)
  Use centralized source of truth for active branches (elastic#17063)
  Update logstash_releases.json (elastic#17055)
  fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039)
  Don't honor VERSION_QUALIFIER if set but empty (elastic#17032)
  Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026)
  Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968)
  Add short living 9.0 next and update main in CI release version definition. (elastic#17008)
  Core version bump to 9.1.0 (elastic#16991)
  Add 9.0 branch to the CI branches definition (elastic#16997)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andsel andsel andsel approved these changes

@mashhurs mashhurs mashhurs approved these changes

Assignees

@dliappis dliappis

Labels

ci v8.16.5 v8.17.3 v8.18.0 v8.19.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dliappis @mashhurs @andsel @elasticmachine @donoghuc