entrypoint: avoid polluting stdout #17125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program.
|
💛 Build succeeded, but was flaky
Failed CI Steps |
donoghuc
approved these changes
Feb 20, 2025
|
@logstashmachine backport 9.0 |
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program. (cherry picked from commit 91258c3)
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program. (cherry picked from commit 91258c3)
2 tasks
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Feb 21, 2025
In elastic#17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream.
1 task
donoghuc
added a commit
that referenced
this pull request
Feb 21, 2025
In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream. (cherry picked from commit 227c0d8)
Merged
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream. (cherry picked from commit 227c0d8)
Merged
1 task
donoghuc
pushed a commit
that referenced
this pull request
Feb 21, 2025
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program. (cherry picked from commit 91258c3) Co-authored-by: Ry Biesemeyer <[email protected]>
donoghuc
pushed a commit
that referenced
this pull request
Feb 21, 2025
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program. (cherry picked from commit 91258c3) Co-authored-by: Ry Biesemeyer <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Feb 21, 2025
…#17139) In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream. (cherry picked from commit 227c0d8) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Feb 21, 2025
…#17140) In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream. (cherry picked from commit 227c0d8) Co-authored-by: Cas Donoghue <[email protected]>
v1v
pushed a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program.
v1v
pushed a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…#17138) In elastic#17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream.
v1v
added a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…gify * upstream/main: (27 commits) Add Windows 2025 to CI (elastic#17133) Update container acceptance tests with stdout/stderr changes (elastic#17138) entrypoint: avoid polluting stdout (elastic#17125) Fix acceptance test assertions for updated plugin remove (elastic#17126) Fix acceptance test assertions for updated plugin `remove` (elastic#17122) plugins: improve `remove` command to support multiple plugins (elastic#17030) spec: improve ls2ls spec (elastic#17114) allow concurrent Batch deserialization (elastic#17050) CPM handle 404 response gracefully with user-friendly log (elastic#17052) qa: use clean expansion of LS tarball per fixture instance (elastic#17082) Allow capturing heap dumps in DRA BK jobs (elastic#17081) Use centralized source of truth for active branches (elastic#17063) Update logstash_releases.json (elastic#17055) fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039) Don't honor VERSION_QUALIFIER if set but empty (elastic#17032) Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026) Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968) Add short living 9.0 next and update main in CI release version definition. (elastic#17008) Core version bump to 9.1.0 (elastic#16991) Add 9.0 branch to the CI branches definition (elastic#16997) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
routes output from setup-related bits in the entrypoint scripts to stderr, so that stdout can include only the output of the actual program.
Why is it important/What is the impact to the user?
This change makes it possible to use the stdout of entrypoints like
bin/logstash-pluginwithout the setup-related pollution:For example, with #17124 addition of
--no-expand, and given anallowlistcontaining the names of plugins to keep,The above is not possible if the stdout of
bin/logstash-plugininvocation is littered with info about the JVM.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
observe that the side-channel bits are on STDERR and can be redirected away
Logs
With patch, the info about which java is being used is on STDERR:
Without patch, the info about which java is being used is on STDOUT: